[Kde-pim] Review Request 113252: Extract messages from javascript wizards

[Laurent Montel]

> On Oct. 15, 2013, 10:18 p.m., Allen Winter wrote:
> > the code is ok.
> > I wonder if we put a min required version kdelibs 4.11.3, however.
> > 
> > krop, Mr. CMake Guru, what do you think?
> 
> Laurent Montel wrote:
>     For 4.12 yes we can put requires 4.11.x
>     for 4.11 no it's not the policy
>     Policy is kdepim-version -1 
>     => 4.11
>     Regards.
> 
> Luigi Toscano wrote:
>     To summarize:
>     1) the patch can't go to 4.11.x because kdepim* should work on kdelibs >=4.10;
>     2) the patch can go to master (->4.12) because the kdelibs requirement will be raised.
>     
>     Am I correct? Can I push it to master?
>     Just please note that the dependency in master should be on 4.11.3, not just 4.11, because of the kdelibs patch.

Yes correct you can commit in master.
Wait that 4.11.3 is release so.
Regards


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113252/#review41795
-----------------------------------------------------------


On Oct. 14, 2013, 10:29 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113252/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 10:29 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Translate the javascript files used in the wizards that were not translated before.
> I was going to commit this directly (as it does not impact the code, and it fixes a long-standing issue), but this change depends on a kdelibs patch which has been committed today (https://git.reviewboard.kde.org/r/113218/), which means kdelibs 4.11.3. The code in this review adds some calls to qsTr(), and when that kdelibs patch is not applied the wizard scripts exit with a run time error (and a blank window). So the code in this review adds an implicit dependency on kdelibs 4.11.3; the cmake code says "kdelibs 4.10, kdepimlibs 4.11". Would it be acceptable?
> 
> 
> Diffs
> -----
> 
>   accountwizard/wizards/tine20/Messages.sh 30a1fec 
>   accountwizard/wizards/tine20/tine20wizard.es 6970b1d 
>   resources/imap/wizard/Messages.sh 8fbc16c 
>   resources/imap/wizard/imapwizard.es dcab06f 
>   resources/kolabproxy/wizard/Messages.sh 5654648 
>   resources/kolabproxy/wizard/kolabwizard.es 842e757 
>   resources/maildir/wizard/Messages.sh 69bb8e9 
>   resources/maildir/wizard/maildirwizard.es af61f8a 
>   resources/mbox/wizard/Messages.sh d720fde 
>   resources/mbox/wizard/mailboxwizard.es 286d4c0 
>   resources/pop3/wizard/Messages.sh fee8e77 
>   resources/pop3/wizard/pop3wizard.js 47262e4 
> 
> Diff: http://git.reviewboard.kde.org/r/113252/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/