[Kde-pim] Review Request 113918: Improve maildir sync and reduce memory usage

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113918/#review43897
-----------------------------------------------------------

Ship it!


Approach in general is sensible, but I'm biased there ;-)

While Kevin is right that this could probably done with a more elegant API, I'm ok with this too since it's a minimal intrusive/low risk approach.

- Volker Krause


On Nov. 18, 2013, 10:25 a.m., Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113918/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 10:25 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Volker Krause.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Use QDirIterator instead of getting the list of mails in a folder as a stringlist. Safe some stats (as QDirIterator already can provide the info) and doesn't require adding all files to the key cache, thus reducing the memory usage for large folders.
> 
> 
> Diffs
> -----
> 
>   resources/maildir/libmaildir/maildir.h b23fb7a 
>   resources/maildir/libmaildir/maildir.cpp 7834b04 
>   resources/maildir/retrieveitemsjob.h 60f3602 
>   resources/maildir/retrieveitemsjob.cpp 5de627f 
> 
> Diff: http://git.reviewboard.kde.org/r/113918/diff/
> 
> 
> Testing
> -------
> 
> Works for me, waiting for more testers with many mails.
> 
> 
> Thanks,
> 
> Andras Mantia
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/