[Kde-pim] Review Request 113750: Fix 286553 - Kmail signed emails invalid in Thunderbird w/ Enigmail

[Sandro Knauß]

> On Nov. 16, 2013, 12:23 p.m., Ingo Klöcker wrote:
> > I haven't checked this with a test case, but I think this fix breaks 7-bit encoded messages bodies that contain quoted-printable-like character sequences. If you need to change the encoding to QPE because of a "From " then you first need to QP-encode the full body text and then do the additional replacements afterward. Just doing the replacements without QP-encoding the original body is too simplistic.
> > 
> > Further, I think that the correct place for this is the QP-encoder (we probably need a special QP-encoder for email which also takes care of "From " and "--") and the logic that checks whether using some CTE is necessary. IIRC this is what was done in KMail1.
> 
> Sandro Knauß wrote:
>     I think, you are right with breaking 7-bit encoded messages.
>     
>     I found messagecomposer/job/singlepartjob.cpp (l70-80) a notice, that 7bit/8bit should not be taken if it signed. But till now singlepartjob has no parameter for signing. So creating a child class for the signing purpose?

see Review Request #113958 for bugfix.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113750/#review43804
-----------------------------------------------------------


On Nov. 9, 2013, 5:36 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113750/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2013, 5:36 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 286553 and 303305
>     http://bugs.kde.org/show_bug.cgi?id=286553
>     http://bugs.kde.org/show_bug.cgi?id=303305
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> replace "From " and "--" at the beginning of lines with encoded versions according to RfC 3156, 3
> Note: If any line begins with the string "From ", it is strongly
>    suggested that either the Quoted-Printable or Base64 MIME encoding be applied.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/job/signjob.cpp 0183963c9b484bef6eb5cf19668ed4bb5bdf84e8 
>   messagecomposer/tests/signjobtest.h d81ad0948a50f2e05283530e253c766d6cd99beb 
>   messagecomposer/tests/signjobtest.cpp ee300f2652fe645ed5dd3ba7824840ebce0f218f 
> 
> Diff: http://git.reviewboard.kde.org/r/113750/diff/
> 
> 
> Testing
> -------
> 
> * create a test for it.
> * test created message with Thunderbird.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/