[Kde-pim] Review Request 113901: Use dedicated slots for handling exactly the actions they should handle

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113901/#review43818
-----------------------------------------------------------

Ship it!


Ship It!

- Volker Krause


On Nov. 16, 2013, 1:57 p.m., Ingo Klöcker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113901/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2013, 1:57 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Use dedicated slots for handling exactly the actions they should handle
> 
> Previously, all actions in the header context menu were handled by the
> same method slotHeaderContextMenuTriggered(), even actions in submenus
> which was clearly not intended. For example, selecting sorting
> By Date/Time of Most Recent in Subtree in the Sorting submenu did also
> enable the Sender column (because the action for showing/hiding the
> Sender column had the same index set as user data as the action for
> sorting By Date/Time of Most Recent in Subtree). Usage of dedicated
> slots attached to the actions' signals instead of a single slot
> attached to the menu's triggered() signal (which is also emitted for
> actions in submenus) fixes this.
> 
> 
> Diffs
> -----
> 
>   messagelist/core/view.h 9e711456abcbf6b81729fe4c9b900c3b7219f20a 
>   messagelist/core/view.cpp 9ebe815459ec2cf5a479c7d7e028c2ef5d57117f 
> 
> Diff: http://git.reviewboard.kde.org/r/113901/diff/
> 
> 
> Testing
> -------
> 
> * changing sorting options no longer changes displayed columns
> * all options in the main context menu still work
> 
> 
> Thanks,
> 
> Ingo Klöcker
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/