[Kde-pim] Review Request 113793: Allow METADATA style entries for both ANNOATEMORE and METADATA mode

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113793/#review43737
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Nov. 14, 2013, 9:08 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113793/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 9:08 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Ottens.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This patch add support for METADATA style entries in GetMetaDataJob/SetMetaDataJob for both METADATA and ANNOTATEMORE mode. This means an annotation of /shared/comment gets translated in the ANNOTATEMORE mode to /comment with attribute "value.shared". This supports of course only a subset of the possible attribute values, but all that is used by the kimap resource, and as ANNOTATEMORE is anyways legacy, all that we have to care about (Everything else is still supported by using the original API).
> 
> This is the foundation for the IMAP resource to expose both shared and private annotations, which we require for kolab. I intend to expose all annotations including /shared or /private prefix in the CollectionAnnotationsAttribute, and adapt users of the CollectionAnnotationsAttribute accordingly. Patches for kdepim-runtime and kdepim will follow.
> 
> 
> Diffs
> -----
> 
>   kimap/tests/setmetadatajobtest.cpp PRE-CREATION 
>   kimap/getmetadatajob.h 0ba43eb65c6985698e80d32fd467dee84093746c 
>   kimap/getmetadatajob.cpp b23449afa552104beb7dec6555c3819330ba00f1 
>   kimap/metadatajobbase.cpp 8edd3444cd309ac33597d8d796a9ae0a5e8f60ac 
>   kimap/metadatajobbase_p.h 140ef20cc6d786878d93db3de1b3b4b54ad55cdc 
>   kimap/setmetadatajob.h 3736539444f9978f9522deb86c78e6ef134044e6 
>   kimap/setmetadatajob.cpp 3822364b1e417ac916df4a058d8e601e4ebb5563 
>   kimap/tests/CMakeLists.txt 51919857c075803867e7bd60d9293e60521aaca0 
>   kimap/tests/getmetadatajobtest.cpp 834358f3eae87dbb50f241afff7523f57f7efeb9 
> 
> Diff: http://git.reviewboard.kde.org/r/113793/diff/
> 
> 
> Testing
> -------
> 
> See unit tests.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/