[Kde-pim] Review Request 113958: fix 7-bit encoded messages bodies that contain quoted-printable-like character sequences when signing.

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113958/#review44019
-----------------------------------------------------------



messagecomposer/job/signjob.cpp
<http://git.reviewboard.kde.org/r/113958/#comment31566>

    replace seems to be unused?



messagecomposer/job/signjob.cpp
<http://git.reviewboard.kde.org/r/113958/#comment31567>

    style: space before last )


- Kevin Krammer


On Nov. 19, 2013, 11:36 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113958/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 11:36 p.m.)
> 
> 
> Review request for KDEPIM, Ingo Klöcker and Kevin Krammer.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Ingo said, the request #113750 breaks 7-bit encoded messages bodies that contain quoted-printable-like character and he was right.
> Replaced QString with QByteArray to not have to many conversions (from Kevin).
> 
> 
> Diffs
> -----
> 
>   messagecomposer/job/signjob.cpp f436d38ac027b52748d49ed71523d36b2def7020 
>   messagecomposer/tests/signjobtest.cpp f4e957a90028e03dad82fe113b9ef3a45b845872 
> 
> Diff: http://git.reviewboard.kde.org/r/113958/diff/
> 
> 
> Testing
> -------
> 
> Updated signing tests
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/