[Kde-pim] Review Request 113750: Fix 286553 - Kmail signed emails invalid in Thunderbird w/ Enigmail

[Sandro Knauß]

> On Nov. 9, 2013, 8:22 p.m., Kevin Krammer wrote:
> > messagecomposer/job/signjob.cpp, line 183
> > <http://git.reviewboard.kde.org/r/113750/diff/1/?file=212256#file212256line183>
> >
> >     I know this has already been committed, but why all the bytearray -> string conversions if all following operations are again on QByteArrays?
> >     Seems like lots of needless from/to conversions
> 
> Sandro Knauß wrote:
>     I'm not that familiar with all these different string classes. The docu for QString is much better in qt-project, that's why I used it.

See Review Request #113958  there I used QByteArray.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113750/#review43301
-----------------------------------------------------------


On Nov. 9, 2013, 5:36 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113750/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2013, 5:36 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 286553 and 303305
>     http://bugs.kde.org/show_bug.cgi?id=286553
>     http://bugs.kde.org/show_bug.cgi?id=303305
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> replace "From " and "--" at the beginning of lines with encoded versions according to RfC 3156, 3
> Note: If any line begins with the string "From ", it is strongly
>    suggested that either the Quoted-Printable or Base64 MIME encoding be applied.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/job/signjob.cpp 0183963c9b484bef6eb5cf19668ed4bb5bdf84e8 
>   messagecomposer/tests/signjobtest.h d81ad0948a50f2e05283530e253c766d6cd99beb 
>   messagecomposer/tests/signjobtest.cpp ee300f2652fe645ed5dd3ba7824840ebce0f218f 
> 
> Diff: http://git.reviewboard.kde.org/r/113750/diff/
> 
> 
> Testing
> -------
> 
> * create a test for it.
> * test created message with Thunderbird.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/