[Kde-pim] Review Request 113941: Remove ifdef for never defined macro

Kevin Funk krf at gmx.de
Fri Nov 29 13:21:34 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113941/
-----------------------------------------------------------

(Updated Nov. 29, 2013, 1:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries, Patrick Spendrin and Patrick von Reth.


Repository: kdepimlibs


Description
-------

Remove ifdef for never defined macro

This fixes a build issue under MSVC. The qHash() function is needed in order
to compile. Since the KDE_DUMMY_QHASH_FUNCTION macro expands to an inline
qHash() function, it is not needed to be exported, or ifdeffed out in case
we're importing the lib.

At some point the generate_export_headers() CMake macro was used to generate export headers which made this macro undefined. Prior to that the MAKE_KABC_LIB macro was defined via kde4_add_library().


Diffs
-----

  kabc/addressee.h b81deba0c9cec6c71980c34aa86fbaefb26b1409 

Diff: http://git.reviewboard.kde.org/r/113941/diff/


Testing
-------


Thanks,

Kevin Funk

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list