[Kde-pim] Review Request 114166: Prepare KPIMUtils::NetworkAccessHelper for removal in KF5.

[Allen Winter]

> On Nov. 27, 2013, 7:47 p.m., Allen Winter wrote:
> > my only tiny concern is that the KPIMUTILS_EXPORT => KPIMUTILS_DEPRECATED_EXPORT change is BIC.
> > 
> > but else ship it.
> >
> 
> Volker Krause wrote:
>     Are you sure just adding the deprecation attribute is BIC? That would make it rather useless, no?

no-no. bad comment on my part.

what I meant was: I don't recall if that change is BC.   But yes it must be. 

so ship it.


- Allen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114166/#review44613
-----------------------------------------------------------


On Nov. 27, 2013, 7:04 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114166/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2013, 7:04 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Prepare KPIMUtils::NetworkAccessHelper for removal in KF5.
> 
> It's only working on WinCE5, with changes to Solid that never made it to
> master.
> 
> 
> There's two more uses in kdepim-runtime I think, I'll remove those as well once this is in. Should also help with untangling the dependencies on kpimutils a bit.
> 
> 
> Diffs
> -----
> 
>   kpimutils/CMakeLists.txt 2d26ccabe43d817198d28f979380b417824b6ad2 
>   kpimutils/networkaccesshelper.h 4ae3759f82e167576076dbde5fd630311a583aba 
>   kpimutils/networkaccesshelper_wince.cpp aa97ff83229b63ef3e0e65f9f5a512e4ef36f0ae 
>   mailtransport/smtp/smtpsession.cpp 7d4fb59caf84af1b41e6d81027d3869a40404826 
> 
> Diff: http://git.reviewboard.kde.org/r/114166/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/