[Kde-pim] Review Request 113855: Make compile on MSVC2010

[Kevin Funk]

> On Nov. 14, 2013, 1:08 p.m., Patrick Spendrin wrote:
> > akonadi/entitycache_p.h, line 444
> > <http://git.reviewboard.kde.org/r/113855/diff/1/?file=214046#file214046line444>
> >
> >     That doesn't seem to be windows specific?

That's why I added a remark in the commit message. One of the original authors (i.e. Dan Vratil) should check if it's correct.


> On Nov. 14, 2013, 1:08 p.m., Patrick Spendrin wrote:
> > akonadi/notes/CMakeLists.txt, line 7
> > <http://git.reviewboard.kde.org/r/113855/diff/1/?file=214047#file214047line7>
> >
> >     removing might not help on Windows at runtime because those casts must not be available at runtime in the dll interface (no exported functions for these casts).

Hm? I'm removing it because remove_definitions already takes care of undefining the QT_NO_FOOBAR flags. Hence, if we leave the -UQT_NO_FOOBAR parameters in CXX_FLAGS it's basically a no-op, no?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113855/#review43660
-----------------------------------------------------------


On Nov. 14, 2013, 12:36 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113855/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 12:36 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Patrick Spendrin.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Make compile on MSVC2010
> 
> Multiple fixes:
> * Use remove_definitions to remove compiler flags, -U via CXX_FLAGS
>   doesn't seem to work for MSVC. Please check if would make sense for
>   the other occurences in akonadi/*/CMakeLists.txt as well
> * Fix an error/typo(?) in entitiycache_p.h. Use template parameter
>   instead of 'Item' class. Please check if this is correct
> * Include ktcpsocket.h for KSslErrorUiData class
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/CMakeLists.txt 5bdb2534ec0428b66a55206cd21a75efbf817cc2 
>   akonadi/entitycache_p.h e08ee3a9b79a2704a58ebd5086b28843841ec2b6 
>   akonadi/notes/CMakeLists.txt 834328d62ca0c12b42d8cdddf533311e7711dfe3 
>   kimap/tests/testimapidle.cpp 1f443af54d872a90ec89cd011c616192683a4b9c 
> 
> Diff: http://git.reviewboard.kde.org/r/113855/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/