[Kde-pim] Review Request 114117: Port Mail Filter Agent to Akonadi::PreprocessorBase

[Dan Vrátil]

> On Nov. 26, 2013, 3:30 p.m., Andras Mantia wrote:
> > agents/mailfilteragent/mailfilteragent.cpp, line 118
> > <http://git.reviewboard.kde.org/r/114117/diff/3/?file=220165#file220165line118>
> >
> >     I need one more explanation here: why the removal of setCacheOnly(true)?
> >     
> >     The fetchCollection(true)->fetchCollection(false) I assume is done, because now the collection is not fetched through the Monitor, right?
> >     
> >     OTOH, I will test and run this patch for a while (I'm a heavy local filter user), please don't commit it before.

Oops, that should have remained there.

fetchCollection is indeed false, because we don't use the Monitor anymore. I'm thinking about adding "enabled" property to Monitor to disable it completely in cases like this.

Thanks for testing!


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114117/#review44501
-----------------------------------------------------------


On Nov. 26, 2013, 2:48 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114117/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 2:48 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> When a new item is stored in Akonadi the server first runs it to chain of preprocessors and only after that it notifies regular clients.
> 
> By porting Mail Filter agent to be a preprocessor, filtering happens before the email reaches KMail. As a result, the emails are not piling in Inbox, and then slowly disappearing into their destination folders, but instead they appear in the correct folders right away.
> 
> 
> There was a bug in PreprocessorBase that prevented preprocessor from registering to D-Bus, which is fixed now. To test this patch, you need Akonadi and kdepimlibs from latest master.
> 
> 
> Diffs
> -----
> 
>   agents/mailfilteragent/filtermanager.h b95fc15 
>   agents/mailfilteragent/filtermanager.cpp a9b76f1 
>   agents/mailfilteragent/mailfilteragent.h c8ca7b4 
>   agents/mailfilteragent/mailfilteragent.cpp 5168cf0 
> 
> Diff: http://git.reviewboard.kde.org/r/114117/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/