[Kde-pim] Review Request 114086: Adding signing & encryption keys in any cases

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114086/#review44322
-----------------------------------------------------------

Ship it!


code is ok, you just moved existing code.
logic seems reasonable.

- Allen Winter


On Nov. 24, 2013, 3:46 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114086/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2013, 3:46 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Make sure that all the selection dialogs can use signing and ecryption keys.
> 
> An example:
> You have configuered the signing and encryption key for an identity.
> -> you can just send enc+sign messages, all ok
> but if you you don't select enc/sign, but the recipient wants encryption/siging
> your mail isn't signed and you get following dialog: 
> "Examination of recipient's signing preferences yielded that the message
> should be signed using OpenPGP, at least for some recipients;
> however, you have not configured valid OpenPGP signing certificates for
> this identity."
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composer/composerviewbase.cpp 4269fcb2ae0844b19624ea021f9c0974898447fb 
> 
> Diff: http://git.reviewboard.kde.org/r/114086/diff/
> 
> 
> Testing
> -------
> 
> Played around with reipient sign/enc preferences and sending mails and test if the settings were taken.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/