[Kde-pim] Review Request 113918: Improve maildir sync and reduce memory usage

[Kevin Krammer]

> On Nov. 18, 2013, 10:48 a.m., Kevin Krammer wrote:
> > Looks good to me!
> > 
> > In general I am wondering though if we might not want something like a MaildirIterator (friend of Maildir), that can be used to iterate through the maildir, doing the new->cur switching or similar things internally.
> 
> Andras Mantia wrote:
>     With the pace I commit to KDE nowadays, we would need a new sprint for that implementation.

True. I was just adding that because anything that happens in maildir can more easily be reused in the other resource(s) using libmaildir, reducing the amount of code duplication and chance of introducing errors.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113918/#review43884
-----------------------------------------------------------


On Nov. 18, 2013, 4:18 p.m., Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113918/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 4:18 p.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Volker Krause.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Use QDirIterator instead of getting the list of mails in a folder as a stringlist. Safe some stats (as QDirIterator already can provide the info) and doesn't require adding all files to the key cache, thus reducing the memory usage for large folders.
> 
> 
> Diffs
> -----
> 
>   resources/maildir/libmaildir/maildir.h b23fb7a 
>   resources/maildir/libmaildir/maildir.cpp 7834b04 
>   resources/maildir/retrieveitemsjob.h 60f3602 
>   resources/maildir/retrieveitemsjob.cpp 5de627f 
> 
> Diff: http://git.reviewboard.kde.org/r/113918/diff/
> 
> 
> Testing
> -------
> 
> Works for me, waiting for more testers with many mails.
> 
> 
> Thanks,
> 
> Andras Mantia
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/