[Kde-pim] Review Request 113941: Remove ifdef for never defined macro

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113941/#review44765
-----------------------------------------------------------


The fix is wrong, you must replace the MAKE_KABC_LIB with KABC_EXPORTS (or however the macro is defined now; check the generated kabc_export.h file for reference). Otherwise you will get multiply defined symbols.

- Patrick Spendrin


On Nov. 20, 2013, 8:17 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113941/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 8:17 a.m.)
> 
> 
> Review request for KDEPIM-Libraries, Patrick Spendrin and Patrick von Reth.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Remove ifdef for never defined macro
> 
> This fixes a build issue under MSVC. The qHash() function is needed in order
> to compile. Since the KDE_DUMMY_QHASH_FUNCTION macro expands to an inline
> qHash() function, it is not needed to be exported, or ifdeffed out in case
> we're importing the lib.
> 
> At some point the generate_export_headers() CMake macro was used to generate export headers which made this macro undefined. Prior to that the MAKE_KABC_LIB macro was defined via kde4_add_library().
> 
> 
> Diffs
> -----
> 
>   kabc/addressee.h b81deba0c9cec6c71980c34aa86fbaefb26b1409 
> 
> Diff: http://git.reviewboard.kde.org/r/113941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/