[Kde-pim] Review Request 113940: Remove copy of auto-generated file

Dan Vrátil dvratil at redhat.com
Tue Nov 19 17:06:15 GMT 2013


> On Nov. 19, 2013, 6:02 p.m., Dan Vrátil wrote:
> > I think you have to add ${CMAKE_CURRENT_BINARY_DIR} to include_directories, otherwise it won't find the generated file.

Ah, sorry, I didn't check where the build fails: you have to add ${CMAKE_BINARY_DIR}/kabc/plugins/file to include_directories in kabc/tests


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113940/#review43960
-----------------------------------------------------------


On Nov. 19, 2013, 4:42 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113940/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 4:42 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Remove copy of auto-generated file
> 
> This file generated by the generate_export_header() CMake macro
> 
> 
> Diffs
> -----
> 
>   kabc/plugins/file/kabc_file_core_export.h 654942b75acb4e8f99ae268b24acee6249b22437 
> 
> Diff: http://git.reviewboard.kde.org/r/113940/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list