[Kde-pim] Review Request 114108: Don't bother IMAP servers with not supported flags - part II

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114108/#review44885
-----------------------------------------------------------

Ship it!


Ship It!

- Christian Mollekopf


On Nov. 25, 2013, 1:30 p.m., André Wöbbeking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114108/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 1:30 p.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> This is a follow up to review request #112724.
> 
> I was confused by the way data is passed to the tasks. In fromAkonadiToSupportedImapFlags() I need a collection to ask for the supported flags. I didn't know that ResourceState::m_collection isn't set in all cases. So I changed fromAkonadiToSupportedImapFlags() to take the collection as parameter and changed all callers.
> 
> BTW, why do the tasks don't get all needed data in the constructor instead of using the ResourceState?
> 
> 
> Diffs
> -----
> 
>   resources/imap/additemtask.cpp af427ff 
>   resources/imap/changeitemsflagstask.cpp d7eb183 
>   resources/imap/changeitemtask.cpp 242e202 
>   resources/imap/resourcetask.h 7a9b107 
>   resources/imap/resourcetask.cpp bba0c47 
> 
> Diff: http://git.reviewboard.kde.org/r/114108/diff/
> 
> 
> Testing
> -------
> 
> Now also forwarding a mail doesn't give an error (the flag is still not stored as it'll be overriden by the next sync but that will be my next review request).
> 
> 
> Thanks,
> 
> André Wöbbeking
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/