[Kde-pim] Review Request 113900: Fix typo in logic looking for index of column for the sort indicator

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113900/#review43826
-----------------------------------------------------------


This review has been submitted with commit 6718e77b427e4dafed73675d36bc15eb9e47c40d by Ingo Klöcker to branch KDE/4.11.

- Commit Hook


On Nov. 16, 2013, 1:38 p.m., Ingo Klöcker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113900/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2013, 1:38 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Fix typo in logic looking for index of column for the sort indicator
> 
> Not 1, but -1, indicates that the column to add the sort indicator to
> has not yet been found. This might not have caused a user visible
> problem because the column with index 1 (in KMail) is Sender/Receiver
> which is found again in the "wider range" lookup.
> 
> 
> Diffs
> -----
> 
>   messagelist/core/widgetbase.cpp ce3ff5005a647ff6e1b20a4ea3634f029c5b9601 
> 
> Diff: http://git.reviewboard.kde.org/r/113900/diff/
> 
> 
> Testing
> -------
> 
> Sorting by different columns still works.
> 
> 
> Thanks,
> 
> Ingo Klöcker
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/