[Kde-pim] Review Request 113895: Removed timestamp check so we update the metadata regulary.

[Christian Mollekopf]

> On Nov. 16, 2013, 10:57 a.m., Kevin Ottens wrote:
> > Any point in keeping is/setSpontaneous() then?

I'm not entirely sure. It's AFAIK only used by the collectionattributessynchronizationjob and the related dbus api of the resource. And this job is only used by the kmail collection properties window to get updated info.

But you're probably right and this should all die.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113895/#review43797
-----------------------------------------------------------


On Nov. 16, 2013, 10:21 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113895/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2013, 10:21 a.m.)
> 
> 
> Review request for KDEPIM, Dan Vrátil and Kevin Ottens.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Removed timestamp check so we update the metadata regulary.
> 
> Just not synchronizing the metadata is not a solution as kolab relies on it to be
> up to date. The performance optimization lies probably in making use of CONDSTORE
> modseq.
> 
> 
> Diffs
> -----
> 
>   resources/imap/retrievecollectionmetadatatask.h 4446c1703b2e9eb0497b83893b8f5fc40567a529 
>   resources/imap/retrievecollectionmetadatatask.cpp f5fd172f58f8cc9e42f4ee0f56f6ac937f218854 
> 
> Diff: http://git.reviewboard.kde.org/r/113895/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/