[Kde-pim] Review Request 114081: Fixes 328013: Kmail Crashes when errors occure while sending mails

Sandro Knauß mail at sandroknauss.de
Sun Nov 24 15:21:52 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114081/
-----------------------------------------------------------

Review request for KDEPIM.


Bugs: 328013
    http://bugs.kde.org/show_bug.cgi?id=328013


Repository: kdepim


Description
-------

When a subjob fails just emitResult right after it ent exit the
function.


Diffs
-----

  messagecomposer/job/encryptjob.cpp 682a2aa397421f5576e6ce906d4c3735367778bc 
  messagecomposer/job/signencryptjob.cpp d91b61ce3c2a56efa840a630e92dd18995a82c09 
  messagecomposer/job/signjob.cpp f436d38ac027b52748d49ed71523d36b2def7020 

Diff: http://git.reviewboard.kde.org/r/114081/diff/


Testing
-------

1. Create a mail
2. remove secect keys (for signing mails) and/or hitting cancel at the pinentry
3. click send button
4. see a valid error message: 
Could not compose message: Falsche Passphrase
the german error stings come from gnupg, in english:
Could not compose message: Wrong passphrase


Thanks,

Sandro Knauß

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list