[Kde-pim] Review Request 113313: coding style for akonadi

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113313/#review43169
-----------------------------------------------------------


I'm not sure if we understand each other. The indentation is not consistent on the first level:

Look at the indentation on line 90: qRegisterMetaType<Akonadi::Response>(); is indented by 4 spaces from left
Look at the indentation on line 335: if ( !DbConfig::configuredDatabase()->useInternalServer() ) { is indented by 2 spaces from left

What I meant originally was to fix the indentation, so that the file uses the same size of indentation everywhere. From the link you sent me I understand that there's no hard rule for 2 or 4 spaces, so it's pretty much up to you to decide whether you want to use 2 or 4 spaces, but it should be same everywhere in the file.

- Dan Vrátil


On Nov. 1, 2013, 7:30 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113313/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 7:30 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> next job for akonadi/server/src
> 
> Please have anew look here
> 
> 
> Diffs
> -----
> 
>   server/src/akonadi.cpp 8433de1 
> 
> Diff: http://git.reviewboard.kde.org/r/113313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/