[Kde-pim] Review Request 114117: Port Mail Filter Agent to Akonadi::PreprocessorBase

Dan Vrátil dvratil at redhat.com
Tue Nov 26 13:48:01 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114117/
-----------------------------------------------------------

(Updated Nov. 26, 2013, 2:48 p.m.)


Review request for KDEPIM.


Changes
-------

Don't always fetch full payload (depends this patch https://git.reviewboard.kde.org/r/114140/ )


Repository: kdepim


Description
-------

When a new item is stored in Akonadi the server first runs it to chain of preprocessors and only after that it notifies regular clients.

By porting Mail Filter agent to be a preprocessor, filtering happens before the email reaches KMail. As a result, the emails are not piling in Inbox, and then slowly disappearing into their destination folders, but instead they appear in the correct folders right away.


There was a bug in PreprocessorBase that prevented preprocessor from registering to D-Bus, which is fixed now. To test this patch, you need Akonadi and kdepimlibs from latest master.


Diffs (updated)
-----

  agents/mailfilteragent/filtermanager.h b95fc15 
  agents/mailfilteragent/filtermanager.cpp a9b76f1 
  agents/mailfilteragent/mailfilteragent.h c8ca7b4 
  agents/mailfilteragent/mailfilteragent.cpp 5168cf0 

Diff: http://git.reviewboard.kde.org/r/114117/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list