[Kde-pim] Review Request 113674: Fixed fetching of items that exited the buffer after being referenced.

Dan Vrátil dvratil at redhat.com
Mon Nov 11 17:31:12 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113674/#review43448
-----------------------------------------------------------


This patch seems to be included in the larger review https://git.reviewboard.kde.org/r/113674/diff/#index_header - should this review be discarded?

- Dan Vrátil


On Nov. 6, 2013, 2:24 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113674/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 2:24 p.m.)
> 
> 
> Review request for KDEPIM, Dan Vrátil, Stephen Kelly, and Volker Krause.
> 
> 
> Bugs: 312460
>     http://bugs.kde.org/show_bug.cgi?id=312460
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Fixed fetching of items that exited the buffer after being referenced.
> 
> After a collection exits the buffer after being referenced,
> the monitor no longer emits updates for this collection.
> It is therefore necessary for the ETM to refetch the items to get missing updates.
> 
> 
> Diffs
> -----
> 
>   akonadi/entitytreemodel_p.cpp 2505fee5dfc001c843019e29d885baa1c492e6f6 
>   akonadi/monitor_p.h 3d3d60b6121365369e1b42b23d2448874886a1d0 
>   akonadi/monitor_p.cpp 778dd752071413b51d68ed97d71f335256be1768 
> 
> Diff: http://git.reviewboard.kde.org/r/113674/diff/
> 
> 
> Testing
> -------
> 
> Tested manually, I'll follow up with unittests.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list