[Kde-pim] Review Request 113577: Fix ImapStreamParser CRLF skipping.
Kevin Ottens
ervin at kde.org
Sun Nov 3 12:12:01 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113577/#review42887
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On Nov. 1, 2013, 9:01 p.m., Christian Mollekopf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113577/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 9:01 p.m.)
>
>
> Review request for KDEPIM and Kevin Ottens.
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> With the code before it was possible that either the carriage return or the newline was not yet parsed, resulting in it ending up as part of the payload.
> This resulted in broken payloads.
>
>
> Diffs
> -----
>
> kimap/tests/streamparsertest.cpp PRE-CREATION
> kimap/tests/CMakeLists.txt d9fb082
> kimap/imapstreamparser.cpp 37bf691
>
> Diff: http://git.reviewboard.kde.org/r/113577/diff/
>
>
> Testing
> -------
>
> works for me
>
>
> Thanks,
>
> Christian Mollekopf
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list