[Kde-pim] Review Request 113890: Improve error handling in maildir by giving back the string error message to the caller

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113890/#review43759
-----------------------------------------------------------



resources/maildir/libmaildir/maildir.cpp
<http://git.reviewboard.kde.org/r/113890/#comment31429>

    I'd say
    bool result = f.open...
    instead of two separate lines



resources/maildir/libmaildir/maildir.cpp
<http://git.reviewboard.kde.org/r/113890/#comment31430>

    maybe even result = result && ...
    i.e. not try to write if open already failed?



resources/maildir/libmaildir/maildir.cpp
<http://git.reviewboard.kde.org/r/113890/#comment31431>

    see above?



resources/maildir/libmaildir/maildir.cpp
<http://git.reviewboard.kde.org/r/113890/#comment31432>

    spaces



resources/maildir/libmaildir/maildir.cpp
<http://git.reviewboard.kde.org/r/113890/#comment31433>

    I would say keep the kDebug()
    if enabled it had additional value because it contains the method name



resources/mixedmaildir/mixedmaildirstore.cpp
<http://git.reviewboard.kde.org/r/113890/#comment31434>

    TODO needs to be in else case



resources/mixedmaildir/mixedmaildirstore.cpp
<http://git.reviewboard.kde.org/r/113890/#comment31437>

    either also in the else or before the if



resources/mixedmaildir/mixedmaildirstore.cpp
<http://git.reviewboard.kde.org/r/113890/#comment31438>

    {} and new line please :)


- Kevin Krammer


On Nov. 15, 2013, 7:31 p.m., Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113890/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 7:31 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Improve error handling in maildir by giving back the string error message to the caller.
> 
> 
> Diffs
> -----
> 
>   resources/mixedmaildir/mixedmaildirstore.cpp 922071c 
>   resources/mixedmaildir/tests/itemfetchtest.cpp 13ac8fa 
>   resources/maildir/configdialog.cpp ebea669 
>   resources/maildir/libmaildir/maildir.h 506e4c7 
>   resources/maildir/libmaildir/maildir.cpp 4a932db 
>   resources/maildir/libmaildir/tests/testmaildir.cpp ed312ea 
>   resources/maildir/maildirresource.cpp 932f7d4 
>   resources/mixedmaildir/configdialog.cpp 9c5a85b 
> 
> Diff: http://git.reviewboard.kde.org/r/113890/diff/
> 
> 
> Testing
> -------
> 
> make test passes.
> 
> 
> Thanks,
> 
> Andras Mantia
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/