[Kde-pim] Review Request 113908: coding style (tabs and indentation to 4) for tabs

[Sergio Luis Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113908/#review43849
-----------------------------------------------------------


I've been doing a lot of work in akonadi/calendar lately so I would like any style fix to go into 4.11 first.
Otherwise it will be frustrating to me to merge anything due to merge conflicts.

Also, last year we agreed on comparing the md5sum of the generated stripped .so library to be sure we don't introduce regressions, can you check that ? Thanks



- Sergio Luis Martins


On Nov. 17, 2013, 10:44 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113908/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2013, 10:44 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> next job for kdepimlibs/akonadi/calender/
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/incidencechanger_p.h 6d3e924 
>   akonadi/calendar/incidencechanger_p.cpp 0e2f6ba 
>   akonadi/calendar/incidencefetchjob_p.h 16d0828 
>   akonadi/calendar/incidencefetchjob_p.cpp dcd27e9 
>   akonadi/calendar/itiphandler.h dd18cdb 
>   akonadi/calendar/itiphandler.cpp 1a9a8c2 
>   akonadi/calendar/itiphandler_p.h 76781ae 
>   akonadi/calendar/itiphandler_p.cpp 27001ec 
>   akonadi/calendar/itiphandlerhelper_p.h f3b70fe 
>   akonadi/calendar/itiphandlerhelper_p.cpp de35fdd 
>   akonadi/calendar/kcolumnfilterproxymodel.cpp b2fff69 
>   akonadi/calendar/kcolumnfilterproxymodel_p.h 052846e 
>   akonadi/calendar/mailclient_p.h cdfb90c 
>   akonadi/calendar/mailclient_p.cpp e5d1439 
>   akonadi/calendar/mailscheduler_p.h 7763503 
>   akonadi/calendar/mailscheduler_p.cpp bd1a750 
>   akonadi/calendar/publishdialog.h ee768c4 
>   akonadi/calendar/publishdialog.cpp 8bab694 
>   akonadi/calendar/publishdialog_p.h f3c80eb 
>   akonadi/calendar/publishdialog_p.cpp 12bfadf 
>   akonadi/calendar/scheduler_p.h 08f1b04 
>   akonadi/calendar/scheduler_p.cpp c51db3f 
>   akonadi/calendar/standardcalendaractionmanager.h 347c2e1 
>   akonadi/calendar/standardcalendaractionmanager.cpp c657427 
>   akonadi/calendar/tests/calendarbasetest.h df66ba2 
>   akonadi/calendar/tests/calendarbasetest.cpp b365bf6 
>   akonadi/calendar/tests/etmcalendartest.h 21072db 
>   akonadi/calendar/tests/etmcalendartest.cpp ba8aa07 
>   akonadi/calendar/tests/fetchjobcalendartest.cpp 0763c76 
>   akonadi/calendar/tests/helper.h 2aee89b 
>   akonadi/calendar/tests/helper.cpp a152345 
>   akonadi/calendar/tests/historytest.cpp 2344c30 
>   akonadi/calendar/tests/incidencechangertest.cpp ea8ed22 
>   akonadi/calendar/tests/itiphandlertest.cpp 9df482f 
>   akonadi/calendar/tests/mailclienttest.cpp a1bf331 
>   akonadi/calendar/tests/todopurgertest.h 7cb5839 
>   akonadi/calendar/tests/todopurgertest.cpp c568d32 
>   akonadi/calendar/tests/unittestbase.h 14dec78 
>   akonadi/calendar/todopurger.cpp 34e9098 
>   akonadi/calendar/utils_p.h e9cf6b9 
>   akonadi/calendar/utils_p.cpp 7c67a31 
>   akonadi/calendar/freebusyproviderbase.h 9b3915f 
>   akonadi/calendar/freebusyproviderbase.cpp 31e7720 
>   akonadi/calendar/freebusyproviderbase_p.h 2a7f98b 
>   akonadi/calendar/history.h 6aab9f7 
>   akonadi/calendar/history.cpp 5a8a725 
>   akonadi/calendar/history_p.h 588dcc2 
>   akonadi/calendar/history_p.cpp c7b55ca 
>   akonadi/calendar/icalimporter.cpp dec5ebe 
>   akonadi/calendar/icalimporter_p.h a1bc51e 
>   akonadi/calendar/incidencechanger.h cb5fae3 
>   akonadi/calendar/incidencechanger.cpp 7ca07a6 
>   akonadi/calendar/blockalarmsattribute.h 5f1c8dd 
>   akonadi/calendar/blockalarmsattribute.cpp fc79f3a 
>   akonadi/calendar/calendarbase.h f8776c1 
>   akonadi/calendar/calendarbase.cpp 7871b2a 
>   akonadi/calendar/calendarbase_p.h d63f74e 
>   akonadi/calendar/calendarclipboard.h 824e753 
>   akonadi/calendar/calendarclipboard.cpp 58a2c0c 
>   akonadi/calendar/calendarclipboard_p.h 4de5a1a 
>   akonadi/calendar/calendarmodel.cpp 42559eb 
>   akonadi/calendar/calendarmodel_p.h 27f5bce 
>   akonadi/calendar/calfilterproxymodel_p.h 7c746d8 
>   akonadi/calendar/calfilterproxymodel_p.cpp a26b07d 
>   akonadi/calendar/etmcalendar.h e51a117 
>   akonadi/calendar/etmcalendar.cpp 8e8b80b 
>   akonadi/calendar/etmcalendar_p.h 670d008 
>   akonadi/calendar/examples/etmcalendar/main.cpp 14234cf 
>   akonadi/calendar/fetchjobcalendar.h 86f536f 
>   akonadi/calendar/fetchjobcalendar.cpp fd13ad7 
>   akonadi/calendar/fetchjobcalendar_p.h 6532e89 
>   akonadi/calendar/freebusydownloadjob_p.h 1a888d7 
>   akonadi/calendar/freebusydownloadjob_p.cpp 4833275 
>   akonadi/calendar/freebusymanager.h e744dda 
>   akonadi/calendar/freebusymanager.cpp 616e49d 
>   akonadi/calendar/freebusymanager_p.h 59978bd 
> 
> Diff: http://git.reviewboard.kde.org/r/113908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/