[Kde-pim] Review Request 114140: Allow PreprocessorBase subclasses to specify fetch scope for each item
Kevin Krammer
krammer at kde.org
Sat Nov 30 16:41:49 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114140/#review44894
-----------------------------------------------------------
akonadi/preprocessorbase.h
<http://git.reviewboard.kde.org/r/114140/#comment32084>
I am not sure you can do this:
http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Add_new_virtuals_to_a_non-leaf_class
- Kevin Krammer
On Nov. 26, 2013, 1:46 p.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114140/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2013, 1:46 p.m.)
>
>
> Review request for KDEPIM-Libraries.
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> Without this, the MailFilter agent would have to fetch full scope every time, which is not the desired behavior (headers are enough usually).
>
> To be able to do this, I've added this method, that is called every time before the ItemFetchJob in PreprocessorBase is invoked and allows subclasses to set a fetch scope depending on the parent collection.
>
>
> Diffs
> -----
>
> akonadi/preprocessorbase.h 94b967e
> akonadi/preprocessorbase.cpp 3f68cbb
> akonadi/preprocessorbase_p.cpp 3ebeb69
>
> Diff: http://git.reviewboard.kde.org/r/114140/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Vrátil
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list