[Kde-pim] Review Request 113907: Nicer job names in KIMAP

Lasse Liehu lasse.liehu at gmail.com
Wed Nov 27 13:40:20 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113907/
-----------------------------------------------------------

(Updated Nov. 27, 2013, 1:40 p.m.)


Review request for KDEPIM.


Repository: kdepimlibs


Description
-------

Following up on http://lists.kde.org/?l=kde-pim&m=137398746102545&w=2

If a job corresponded to an IMAP command that I wasn’t able to describe in a user-friendlier way, I changed the job name to “IDLE command” and similar because I thought that is probably easier to understand and translate than “Idle failed”. Better ideas welcome.


Diffs
-----

  kimap/selectjob.cpp 71732f9 
  kimap/setacljob.cpp c1144de 
  kimap/setmetadatajob.cpp 2938d1f 
  kimap/setquotajob.cpp 6b05b3c 
  kimap/storejob.cpp c0f222d 
  kimap/subscribejob.cpp 89f1e76 
  kimap/unsubscribejob.cpp 4331f79 
  kimap/myrightsjob.cpp fa6e0f1 
  kimap/namespacejob.cpp 4176f8b 
  kimap/quotajobbase.cpp 7a48b44 
  kimap/renamejob.cpp 80b396e 
  kimap/searchjob.cpp 5842c4c 
  kimap/copyjob.cpp 97e7109 
  kimap/createjob.cpp 4a45479 
  kimap/deleteacljob.cpp 658caae 
  kimap/deletejob.cpp 6709d94 
  kimap/expungejob.cpp 483ca38 
  kimap/fetchjob.cpp fa49fbd 
  kimap/getacljob.cpp 054e989 
  kimap/getmetadatajob.cpp 8c13fbb 
  kimap/getquotajob.cpp 005b930 
  kimap/getquotarootjob.cpp 71f3a95c 
  kimap/idlejob.cpp 0075473 
  kimap/job.cpp 4a6d41f 
  kimap/job_p.h 6e4b717 
  kimap/listjob.cpp 755187b 
  kimap/listrightsjob.cpp aa478e1 
  kimap/loginjob.cpp 768794f 
  kimap/logoutjob.cpp de552b6 
  kimap/metadatajobbase.cpp 2b32cb3 
  kimap/acljobbase.cpp 7a3660e 
  kimap/appendjob.cpp 5035214 
  kimap/capabilitiesjob.cpp f2d2605 
  kimap/closejob.cpp d84d247 

Diff: http://git.reviewboard.kde.org/r/113907/diff/


Testing
-------

Compilation


Thanks,

Lasse Liehu

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list