[Kde-pim] Review Request 109259: Remove inode/directory from MailCommon::FolderCollectionMonitor

Dan Vrátil dvratil at redhat.com
Thu May 30 16:45:15 BST 2013



> On May 30, 2013, 12:19 a.m., Allen Winter wrote:
> > Was this ever committed?

No, it was not (didn't get ship it and forgot about it completely). I'll push it tomorrow if nobody objects.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109259/#review33386
-----------------------------------------------------------


On March 3, 2013, 3:59 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109259/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 3:59 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> Don't watch collections in KMail that KMail is not really interested in. This should improve performance a bit and fix a problem, that removing a completely unrelated resource (like Google Calendar) was totally messing up KMail's folder view (usually leading to crash).
> 
> I assume this was added as a workaround for a bug in Monitor, that collections trees where the root collection did not match the mimetype filter were ignored. This has been fixed some time ago, so this is not needed anymore.
> 
> 
> Diffs
> -----
> 
>   mailcommon/foldercollectionmonitor.cpp 49de537 
> 
> Diff: http://git.reviewboard.kde.org/r/109259/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list