[Kde-pim] Review Request 110671: KMail search window: trigger search when pressing return from search field

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110671/
-----------------------------------------------------------

(Updated May 30, 2013, 12:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Laurent Montel.


Description
-------

This patch is a bit more complex than the others: it makes it possible to start searching when pressing enter while typing a search criteria. For this to work, I had to add a "returnPressed()" signal to RegExpLineEdit and propagate it up to SearchWindow. I also removed the code which disabled widgets when a search was done because a) the focus was not being returned properly to the line edit after pressing enter and b) I don't think disabling widgets is needed (maybe it was necessary before Akonadi)


Diffs
-----

  kmail/searchwindow.h bdfe98b6c276f3caa4fadde946b6e60714f3b1aa 
  kmail/searchwindow.cpp 2ec42eaaa89cad7a693f7a1ed526622d842336e1 
  mailcommon/regexplineedit.h a7ce40dcc7a44450077a75e0e1ffc0afb8cd0458 
  mailcommon/regexplineedit.cpp 1fd2b05181f7e63692255957c242e4142d667262 
  mailcommon/rulewidgethandlermanager.cpp 6560eacfd0ab5c78d83d15c2cff9ad661dab93c3 
  mailcommon/searchpatternedit.h 318b7b360894dfff5319c46cb15bfe121ce23b2e 
  mailcommon/searchpatternedit.cpp b747d0a36500dbfcdb5327af54068a4662277a4d 

Diff: http://git.reviewboard.kde.org/r/110671/diff/


Testing
-------


Thanks,

Aurélien Gâteau

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/