[Kde-pim] Review Request 110647: Gid support for akonadi

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110647/#review33148
-----------------------------------------------------------


Thanks for looking into this!


libs/protocol_p.h
<http://git.reviewboard.kde.org/r/110647/#comment24510>

    Unrelated changes?



libs/protocol_p.h
<http://git.reviewboard.kde.org/r/110647/#comment24511>

    There are a few places where AKONADI_[CMD|PARAM]_GID could be used instead of "GID".



server/src/akonadiconnection.cpp
<http://git.reviewboard.kde.org/r/110647/#comment24512>

    This will cause trouble since master is on protocol version 32 (and 31 refers to a different change there). This entire feature should go into master instead I think to avoid this problem.



server/src/handler/fetchhelper.cpp
<http://git.reviewboard.kde.org/r/110647/#comment24513>

    unrelated changes?



server/src/storage/datastore.cpp
<http://git.reviewboard.kde.org/r/110647/#comment24514>

    This is the price for the separate GID table: Two more db operations for every write to an item (Gid::exists triggers a SELECT). That's why I'd prefer to have this inline in the item table.


- Volker Krause


On May 26, 2013, 11:35 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110647/
> -----------------------------------------------------------
> 
> (Updated May 26, 2013, 11:35 a.m.)
> 
> 
> Review request for Akonadi and Volker Krause.
> 
> 
> Description
> -------
> 
> Support for Gid (globally unique identifier).
>     
> This patch adds a new table for the gid of an item.
> Support for:
> * append commands
> * store command
> * fetch command
>     
> Cleanup of gid table works via ON DELETE CASCADE
> 
> 
> Diffs
> -----
> 
>   libs/protocol_p.h fa50b7dfb25dd4231e106e732317ec5e9f1607ef 
>   server/src/akonadiconnection.cpp 4ea3d0ed31efc6a41f7453a4af96d527bc8af0c6 
>   server/src/handler/akappend.cpp 4253c42a810e4f478c12afba1f6988a6a8e2a0e5 
>   server/src/handler/append.cpp 2928fa47911da3b3c98d215bae54c51ef5e8c811 
>   server/src/handler/fetch.cpp 83bb08921cbfa095f68df6c966568baec74a631d 
>   server/src/handler/fetchhelper.h 1124f57d9bef9f8d5cda4498350775d997a33b3e 
>   server/src/handler/fetchhelper.cpp 2a2b4ece8a46f206f48081f46b8859d27ed98f07 
>   server/src/handler/scope.h f2fefb0c2e27e27945b6d1074ae0a11f82ee4e2f 
>   server/src/handler/scope.cpp fe4ad885ede634565b3494344568b7e91ca13877 
>   server/src/handler/store.h 6f331b3b6270d70b993afd9ab498c4c5b064413e 
>   server/src/handler/store.cpp 5868a49031f801b9a8a14db378a43a316f4cb069 
>   server/src/storage/akonadidb.xml 4a560ac44f52062562c40605c8f9e2ca7173ae31 
>   server/src/storage/datastore.h 358d380458db060d917cb177390419b206b64c91 
>   server/src/storage/datastore.cpp c7a47dbd185435f29ee23f4ecfe4f196b5e8e6e4 
>   server/src/storage/itemqueryhelper.h 08d2a85afd18894c72b4ca0cb6b82238d1b11c9a 
>   server/src/storage/itemqueryhelper.cpp 15b5774bf5b68834ae2f2f7ee164f1297c0a92f5 
>   server/tests/unittest/scopetest.cpp c6c720c9438b1fd65d30dc340920d85ca1555f7e 
> 
> Diff: http://git.reviewboard.kde.org/r/110647/diff/
> 
> 
> Testing
> -------
> 
> tests in kdepimlibs
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/