[Kde-pim] Review Request 110510: Add dumpMemoryInfo() to org.kde.dfaure interface

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110510/#review32750
-----------------------------------------------------------



akonadi/resourcebase.h
<http://git.reviewboard.kde.org/r/110510/#comment24332>

    yes please add some doxygen comments for these 2 new methods as well as @since



akonadi/resourcebase.cpp
<http://git.reviewboard.kde.org/r/110510/#comment24333>

    malloc.h isn't a standard header
    
    do you need to put this into an if __GLIBC__ block?
    
    else you'll need to wrap it in a HAVE_MALLOC_H block. which means adding some CMake magic.


- Allen Winter


On May 18, 2013, 4:20 p.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110510/
> -----------------------------------------------------------
> 
> (Updated May 18, 2013, 4:20 p.m.)
> 
> 
> Review request for KDEPIM, David Faure and Volker Krause.
> 
> 
> Description
> -------
> 
> This will let you check if the culprit of high memory usage is glibc's malloc implementation policies.
> Look for very high values on "fsmblks".
> 
> 
> check man mallinfo for more info.
> 
> 
> Diffs
> -----
> 
>   akonadi/resourcebase.cpp faaf573 
>   akonadi/resourcebase.h f757dde 
> 
> Diff: http://git.reviewboard.kde.org/r/110510/diff/
> 
> 
> Testing
> -------
> 
> yep
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/