[Kde-pim] Review Request 110307: Implement recurrence-id support (kdepimlibs)

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110307/#review32040
-----------------------------------------------------------


looks great overall.


akonadi/calendar/calendarbase.h
<http://git.reviewboard.kde.org/r/110307/#comment23976>

    @since 4.11



kcalcore/CMakeLists.txt
<http://git.reviewboard.kde.org/r/110307/#comment23977>

    what? not keeping alphabetical order? tsk :)



kcalcore/calendar.h
<http://git.reviewboard.kde.org/r/110307/#comment23978>

    @since 4.11



kcalcore/incidence.h
<http://git.reviewboard.kde.org/r/110307/#comment23979>

    @since 4.11



kcalcore/incidence.h
<http://git.reviewboard.kde.org/r/110307/#comment23980>

    also add @since 4.11



kcalcore/occurrenceiterator.h
<http://git.reviewboard.kde.org/r/110307/#comment23981>

    @since 4.11



kcalcore/occurrenceiterator.h
<http://git.reviewboard.kde.org/r/110307/#comment23869>

    you need to have /** for doxygen to pick up the comment.
    
    so change 
    /*
    to
    /***



kcalcore/occurrenceiterator.cpp
<http://git.reviewboard.kde.org/r/110307/#comment23982>

    this file could use some coding style love.


- Allen Winter


On May 4, 2013, 11:44 p.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110307/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 11:44 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries, Christian Mollekopf, and David Jarvie.
> 
> 
> Description
> -------
> 
> Uploading this review on behalf of Christian.
> This is the kdepimlibs "recurrences" branch.
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/calendarbase.h 27fc428 
>   akonadi/calendar/calendarbase.cpp b21d07d 
>   akonadi/calendar/calendarclipboard.cpp 0bdaf60 
>   akonadi/calendar/etmcalendar.cpp 00ecffb 
>   akonadi/calendar/fetchjobcalendar.cpp 668641b 
>   akonadi/calendar/incidencechanger.cpp 09f1280 
>   akonadi/calendar/mailscheduler_p.cpp 7559cac 
>   kcalcore/CMakeLists.txt 19ad338 
>   kcalcore/calendar.h 151e639 
>   kcalcore/calendar.cpp cd80b58 
>   kcalcore/calfilter.cpp 8b316f9 
>   kcalcore/event.cpp fc309a6 
>   kcalcore/icalformat.cpp 96cde43 
>   kcalcore/icalformat_p.cpp b7133ce 
>   kcalcore/incidence.h 6c272f7 
>   kcalcore/incidence.cpp d806ffa 
>   kcalcore/incidencebase.cpp fb37487 
>   kcalcore/memorycalendar.cpp 2b622fd 
>   kcalcore/occurrenceiterator.h PRE-CREATION 
>   kcalcore/occurrenceiterator.cpp PRE-CREATION 
>   kcalcore/recurrencerule.h bb61a71 
>   kcalcore/recurrencerule.cpp 958b990 
>   kcalcore/tests/CMakeLists.txt 3e1d600 
>   kcalcore/tests/data/test_recurrenceid.ics PRE-CREATION 
>   kcalcore/tests/data/test_recurrenceid_single.ics PRE-CREATION 
>   kcalcore/tests/data/test_recurrenceid_thisandfuture.ics PRE-CREATION 
>   kcalcore/tests/testmemorycalendar.h c1d2261 
>   kcalcore/tests/testmemorycalendar.cpp e6a30cb 
>   kcalcore/tests/testoccurrenceiterator.h PRE-CREATION 
>   kcalcore/tests/testoccurrenceiterator.cpp PRE-CREATION 
>   kcalcore/tests/testreadrecurrenceid.h PRE-CREATION 
>   kcalcore/tests/testreadrecurrenceid.cpp PRE-CREATION 
>   kcalcore/tests/testrecurrenceexception.h PRE-CREATION 
>   kcalcore/tests/testrecurrenceexception.cpp PRE-CREATION 
>   kcalcore/tests/testrecurtodo.h 78aa077 
>   kcalcore/tests/testrecurtodo.cpp d1b4c3e 
>   kcalcore/tests/testtimesininterval.h 2c05b89 
>   kcalcore/tests/testtimesininterval.cpp 11ae843 
>   kcalcore/tests/testtodo.cpp 7d5edfa 
>   kcalcore/todo.cpp 44228ef 
>   kcalutils/dndfactory.cpp 7a5f6ca 
>   kcalutils/incidenceformatter.cpp 92682be 
> 
> Diff: http://git.reviewboard.kde.org/r/110307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/