[Kde-pim] Review Request 110370: [KMail] Fixes for KMSystemTray

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110370/
-----------------------------------------------------------

(Updated May 9, 2013, 2:33 p.m.)


Review request for KDEPIM.


Description (updated)
-------

Small fixes for KMSystemTray:

* use the kmkernel macro consistently throughout
* change buildPopupMenu to a bool method.
* in buildPopupMenu, return first thing if no mainwidget; thereby eliminating a possible useless leak of a KMenu pointer
* in slotContextMenuAboutToShow, detect if building the popup has failed and quit first thing if it did.  This might fix bug 319254

could be a candidate for 4.10 as well


This addresses bug 319254.
    http://bugs.kde.org/show_bug.cgi?id=319254


Diffs
-----

  kmail/kmsystemtray.h 73048ba 
  kmail/kmsystemtray.cpp 6d027c0 

Diff: http://git.reviewboard.kde.org/r/110370/diff/


Testing
-------


Thanks,

Allen Winter

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/