[Kde-pim] Review Request 110213: Fixes Bug 314422 - Akonadi Plugin: Better placeholders

[Vedant Agarwala]

> On April 27, 2013, 9:44 a.m., Peter Grasch wrote:
> > Looks good.
> > Have you tried it out yet? If not, please do so.
> > Have a look in the Simon manual (section: Akonadi command plugin) if you need help, this is a bit of an advanced feature.

hello Peter,
I was unable to configure simon after few attempts after going through the manual, so I left it. Please could you get someone else to try it?


- Vedant


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110213/#review31664
-----------------------------------------------------------


On April 27, 2013, 9:22 a.m., Vedant Agarwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110213/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 9:22 a.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> Earlier (%1, %2, %3, %4) were the placeholders used by Akonadi plugins reminder system for (summary, date, time, location). Now the placeholders are (%summary, %date, %time, %location).
> 
> 
> This addresses bug 314422.
>     http://bugs.kde.org/show_bug.cgi?id=314422
> 
> 
> Diffs
> -----
> 
>   plugins/Commands/Akonadi/akonadiconfiguration.cpp ad52e8e 
>   plugins/Commands/Akonadi/akonadiconfigurationdlg.ui e75f472 
>   plugins/Commands/Akonadi/alarmscheduleitem.cpp 3c924b1 
> 
> Diff: http://git.reviewboard.kde.org/r/110213/diff/
> 
> 
> Testing
> -------
> 
> Builds and installs successfully.
> 
> 
> Thanks,
> 
> Vedant Agarwala
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/