[Kde-pim] Review Request 110308: Implement recurrence-id support (kdepim)

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110308/#review32231
-----------------------------------------------------------



calendarviews/agenda/agenda.cpp
<http://git.reviewboard.kde.org/r/110308/#comment23983>

    not crazy about the variable name 'i'.
    
    can you think of something a bit more descriptive?  maybe 'thisIncidence' or 'tmpInc' ?



calendarviews/agenda/agendaview.cpp
<http://git.reviewboard.kde.org/r/110308/#comment23984>

    CamelCase headers please.
    
    so this means you'll need to create on OccurenceIterator forwarding header for kdepimlibs changes.



calendarviews/month/monthview.cpp
<http://git.reviewboard.kde.org/r/110308/#comment23985>

    CamelCase header goes here



calendarviews/month/monthview.cpp
<http://git.reviewboard.kde.org/r/110308/#comment23986>

    not crazy about the variable name 'rIt'.
    
    how about 'occurIter'?



calendarviews/timeline/timelineview_p.cpp
<http://git.reviewboard.kde.org/r/110308/#comment23987>

    CamelCase header please



calendarviews/timeline/timelineview_p.cpp
<http://git.reviewboard.kde.org/r/110308/#comment23988>

    rIt => occurIter


- Allen Winter


On May 4, 2013, 9:33 p.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110308/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 9:33 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> Uploading this review on behalf of Christian.
> This is the kdepim "recurrences" branch.
> 
> Also have a look at the kdepimlibs counterpart ( https://git.reviewboard.kde.org/r/110307/ )
> 
> 
> Diffs
> -----
> 
>   calendarsupport/calendarutils.cpp 55c003b 
>   calendarsupport/utils.h eaf4c80 
>   calendarsupport/utils.cpp 98a582c 
>   calendarviews/agenda/agenda.h c6251c6 
>   calendarviews/agenda/agenda.cpp a429120 
>   calendarviews/agenda/agendaitem.h 2e08e5f 
>   calendarviews/agenda/agendaitem.cpp f5ca839 
>   calendarviews/agenda/agendaview.h 5b9ecb5 
>   calendarviews/agenda/agendaview.cpp 8719492 
>   calendarviews/eventview.h 86810cf 
>   calendarviews/eventview.cpp 9f0f1be 
>   calendarviews/journal/journalview.cpp b915034 
>   calendarviews/list/listview.cpp 71981f1 
>   calendarviews/month/monthitem.h 1cc43f9 
>   calendarviews/month/monthitem.cpp d7397d6 
>   calendarviews/month/monthview.cpp 4460ace 
>   calendarviews/timeline/timelineitem.cpp 2599dbc 
>   calendarviews/timeline/timelineview.cpp 1059834 
>   calendarviews/timeline/timelineview_p.cpp 64fb33e 
>   calendarviews/todo/todoview.cpp 7e4e59d 
>   calendarviews/whatsnext/whatsnextview.cpp 229c151 
>   incidenceeditor-ng/dialogdesktop.ui fa83c3b 
>   incidenceeditor-ng/dialogmoremobile.ui 18267b2 
>   incidenceeditor-ng/incidencedialog.cpp a0163fd 
>   incidenceeditor-ng/incidencerecurrence.h 73425bb 
>   incidenceeditor-ng/incidencerecurrence.cpp b82fde7 
>   korganizer/calendarview.h acbcb16 
>   korganizer/calendarview.cpp 2c2c9d6 
> 
> Diff: http://git.reviewboard.kde.org/r/110308/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/