[Kde-pim] Review Request 110632: More KMail search window refinements

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110632/#review33163
-----------------------------------------------------------

Ship it!


Seems good.
Ship it.

- Laurent Montel


On May 24, 2013, 2:08 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110632/
> -----------------------------------------------------------
> 
> (Updated May 24, 2013, 2:08 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> This set of patches change the following:
> 
> - Do not show tree decoration on list: Since the result list is flat, hidding tree decorations saves a bit of horizontal space.
> 
> - Simplify around the SearchPatternEdit widget: Before the patch, the SearchPatternEdit had a small margin to the left, which looked odd IMO. I removed it and inserted an horizontal line to separate the two groups of radio buttons
> 
> 
> Diffs
> -----
> 
>   kmail/ui/searchwindow.ui a392e7aacb56a1532d4811e604b1fea2ceb5e90d 
>   mailcommon/filter/kmfilterdialog.cpp d7237a854eb426c68986aeaf2b0f26db08a9c9cf 
>   mailcommon/searchpatternedit.cpp 10174f64939f964db9fd0f27b57ed00e1db430a2 
> 
> Diff: http://git.reviewboard.kde.org/r/110632/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Before - After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/24/kmail2.png
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/