[Kde-pim] Review Request 110619: Support for url property in kcalcore

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110619/#review33176
-----------------------------------------------------------

Ship it!


looks good other than a couple of small nits.  else ship it.


kcalcore/incidencebase.h
<http://git.reviewboard.kde.org/r/110619/#comment24554>

    unless required, could you keep FieldUnknown listed as the last enumerator?



kcalcore/incidencebase.cpp
<http://git.reviewboard.kde.org/r/110619/#comment24555>

    please add a comment on this line with a short description of the purpose.


- Allen Winter


On May 26, 2013, 3:49 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110619/
> -----------------------------------------------------------
> 
> (Updated May 26, 2013, 3:49 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Support for the standard url property which is used by many calendaring application and is also required for kolab.
> 
> 
> Diffs
> -----
> 
>   kcalcore/icalformat_p.cpp 62a919e5cc33c3842910a92c1062b17f92204533 
>   kcalcore/incidencebase.h 318d4c55824902ecca91eb08ced205e33d315d3f 
>   kcalcore/incidencebase.cpp 110965a215395c680f6dddf6b8b4ce0122be2c8f 
> 
> Diff: http://git.reviewboard.kde.org/r/110619/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/