[Kde-pim] Review Request 110268: Nepomuk Feeder: Simplify change recording logic

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110268/#review32104
-----------------------------------------------------------


This review has been submitted with commit cdca1b1e61c7bbd6ce73265cd13ec9811a7c7962 by Vishesh Handa to branch master.

- Commit Hook


On May 5, 2013, 1:35 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110268/
> -----------------------------------------------------------
> 
> (Updated May 5, 2013, 1:35 p.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Description
> -------
> 
>    Only record changes when we are not online. We get notified normally
>    otherwise because we are an Observer.
>     
>    Also removed the superflous variables which could be simplified into
>    isOnline()
> 
> 
> Diffs
> -----
> 
>   agents/nepomukfeeder/nepomukfeederagent.h eafe5cd 
>   agents/nepomukfeeder/nepomukfeederagent.cpp 7380a32 
> 
> Diff: http://git.reviewboard.kde.org/r/110268/diff/
> 
> 
> Testing
> -------
> 
> works. Changes are being recorded when we are not online.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/