[Kde-pim] Review Request 110417: Small fixes for KMSystemTray

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110417/
-----------------------------------------------------------

(Updated May 14, 2013, 10:51 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM.


Description
-------

Small fixes for KMSystemTray:

* use the kmkernel macro consistently throughout
* change buildPopupMenu to a bool method.
* in buildPopupMenu, return first thing if no mainwidget; thereby eliminating a possible useless leak of a KMenu pointer
* in slotContextMenuAboutToShow, detect if building the popup has failed and quit first thing if it did.  This might fix bug 319254


Diffs
-----

  kmail/kmsystemtray.h 73048ba 
  kmail/kmsystemtray.cpp 6d027c0 

Diff: http://git.reviewboard.kde.org/r/110417/diff/


Testing
-------


Thanks,

Allen Winter

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/