[Kde-pim] Review Request 110268: Nepomuk Feeder: Simplify change recording logic

Vishesh Handa me at vhanda.in
Sun May 5 14:35:43 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110268/
-----------------------------------------------------------

(Updated May 5, 2013, 1:35 p.m.)


Review request for KDEPIM and Christian Mollekopf.


Changes
-------

Removed the change recording logic alltogether


Description
-------

   Only record changes when we are not online. We get notified normally
   otherwise because we are an Observer.
    
   Also removed the superflous variables which could be simplified into
   isOnline()


Diffs (updated)
-----

  agents/nepomukfeeder/nepomukfeederagent.h eafe5cd 
  agents/nepomukfeeder/nepomukfeederagent.cpp 7380a32 

Diff: http://git.reviewboard.kde.org/r/110268/diff/


Testing
-------

works. Changes are being recorded when we are not online.


Thanks,

Vishesh Handa

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list