[Kde-pim] Review Request 110597: Rework KMail search dialog

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110597/#review33020
-----------------------------------------------------------

Ship it!


Seems good.
Ship it


But "I am not done yet. Among other things, I want to improve the PatternEdit,", Patternedit UI is used in filter dialog box and in new autogenerate sieve script, and we will enter in feature freeze, so I prefer that we don't change it in 4.11. For 4.12 we can look at what we must do.

- Laurent Montel


On May 22, 2013, 3:46 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110597/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 3:46 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> This first patch does the following:
> - Changes the orientation of the search dialog buttons
> - Merge the Search and Stop buttons
> - Move the status info to the left of the Search, Close buttons.
> 
> These changes gives more room to the result list and gives the dialog a more "classic" look.
> 
> I am not done yet. Among other things, I want to improve the PatternEdit, but I'd rather get those changes reviewed first instead of proposing a massive diff.
> 
> 
> Diffs
> -----
> 
>   kmail/ui/searchwindow.ui 4fdb19e048afb12654aee81b211223d38ff11669 
>   kmail/searchwindow.cpp 27a02af782264dde80b3e7e39fe1a35268cda526 
>   kmail/searchwindow.h 69f1e2fa3d372ac71598c4106c954e1dfa744bf3 
> 
> Diff: http://git.reviewboard.kde.org/r/110597/diff/
> 
> 
> Testing
> -------
> 
> Searching still works as before.
> 
> 
> File Attachments
> ----------------
> 
> Before - After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/22/kmail.png
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/