[Kde-pim] Review Request 110274: Correctly parse no rights in the imapaclattribute

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110274/#review32101
-----------------------------------------------------------

Ship it!


Looks good to me.

- Volker Krause


On May 2, 2013, 4:24 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110274/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 4:24 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Currently if there are no rights set (id %) instead of (id value %), the code erroneously translates the id to rights, leading to broken behaviour if one explicitly sets no rights for a user (the user receives rights). This patch fixes this, improves the test to test attribute parsing, and also refactors the code a bit to avoid further code duplication.
> 
> The attribute code is copied in kdepim, so it might make sense to move the whole attribute to kdepimlibs. Otherwise I'll just apply the same patch in kdepim as well.
> 
> 
> Diffs
> -----
> 
>   resources/shared/imapaclattribute.cpp ebd8f47 
>   resources/shared/tests/imapaclattributetest.cpp 4f490d0 
> 
> Diff: http://git.reviewboard.kde.org/r/110274/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/