[Kde-pim] Review Request 110308: Implement recurrence-id support (kdepim)

[Christian Mollekopf]

> On May 7, 2013, 10:25 p.m., Allen Winter wrote:
> > calendarviews/agenda/agenda.cpp, line 1885
> > <http://git.reviewboard.kde.org/r/110308/diff/1/?file=142158#file142158line1885>
> >
> >     not crazy about the variable name 'i'.
> >     
> >     can you think of something a bit more descriptive?  maybe 'thisIncidence' or 'tmpInc' ?

Fixed


> On May 7, 2013, 10:25 p.m., Allen Winter wrote:
> > calendarviews/agenda/agendaview.cpp, line 44
> > <http://git.reviewboard.kde.org/r/110308/diff/1/?file=142162#file142162line44>
> >
> >     CamelCase headers please.
> >     
> >     so this means you'll need to create on OccurenceIterator forwarding header for kdepimlibs changes.

Fixed


> On May 7, 2013, 10:25 p.m., Allen Winter wrote:
> > calendarviews/month/monthview.cpp, line 36
> > <http://git.reviewboard.kde.org/r/110308/diff/1/?file=142169#file142169line36>
> >
> >     CamelCase header goes here

Fixed


> On May 7, 2013, 10:25 p.m., Allen Winter wrote:
> > calendarviews/month/monthview.cpp, line 513
> > <http://git.reviewboard.kde.org/r/110308/diff/1/?file=142169#file142169line513>
> >
> >     not crazy about the variable name 'rIt'.
> >     
> >     how about 'occurIter'?

Fixed


> On May 7, 2013, 10:25 p.m., Allen Winter wrote:
> > calendarviews/timeline/timelineview_p.cpp, line 35
> > <http://git.reviewboard.kde.org/r/110308/diff/1/?file=142172#file142172line35>
> >
> >     CamelCase header please

Fixed


> On May 7, 2013, 10:25 p.m., Allen Winter wrote:
> > calendarviews/timeline/timelineview_p.cpp, line 128
> > <http://git.reviewboard.kde.org/r/110308/diff/1/?file=142172#file142172line128>
> >
> >     rIt => occurIter

Fixed


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110308/#review32231
-----------------------------------------------------------


On May 4, 2013, 9:33 p.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110308/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 9:33 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> Uploading this review on behalf of Christian.
> This is the kdepim "recurrences" branch.
> 
> Also have a look at the kdepimlibs counterpart ( https://git.reviewboard.kde.org/r/110307/ )
> 
> 
> Diffs
> -----
> 
>   calendarsupport/calendarutils.cpp 55c003b 
>   calendarsupport/utils.h eaf4c80 
>   calendarsupport/utils.cpp 98a582c 
>   calendarviews/agenda/agenda.h c6251c6 
>   calendarviews/agenda/agenda.cpp a429120 
>   calendarviews/agenda/agendaitem.h 2e08e5f 
>   calendarviews/agenda/agendaitem.cpp f5ca839 
>   calendarviews/agenda/agendaview.h 5b9ecb5 
>   calendarviews/agenda/agendaview.cpp 8719492 
>   calendarviews/eventview.h 86810cf 
>   calendarviews/eventview.cpp 9f0f1be 
>   calendarviews/journal/journalview.cpp b915034 
>   calendarviews/list/listview.cpp 71981f1 
>   calendarviews/month/monthitem.h 1cc43f9 
>   calendarviews/month/monthitem.cpp d7397d6 
>   calendarviews/month/monthview.cpp 4460ace 
>   calendarviews/timeline/timelineitem.cpp 2599dbc 
>   calendarviews/timeline/timelineview.cpp 1059834 
>   calendarviews/timeline/timelineview_p.cpp 64fb33e 
>   calendarviews/todo/todoview.cpp 7e4e59d 
>   calendarviews/whatsnext/whatsnextview.cpp 229c151 
>   incidenceeditor-ng/dialogdesktop.ui fa83c3b 
>   incidenceeditor-ng/dialogmoremobile.ui 18267b2 
>   incidenceeditor-ng/incidencedialog.cpp a0163fd 
>   incidenceeditor-ng/incidencerecurrence.h 73425bb 
>   incidenceeditor-ng/incidencerecurrence.cpp b82fde7 
>   korganizer/calendarview.h acbcb16 
>   korganizer/calendarview.cpp 2c2c9d6 
> 
> Diff: http://git.reviewboard.kde.org/r/110308/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/