[Kde-pim] Review Request 109367: Mark ObjectTreeParser::rawDecryptedBody as deprecated

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109367/#review28879
-----------------------------------------------------------


This review has been submitted with commit 9b82d8d53b3418f9569c6e4fe9d2d6fb1d3757a1 by Sandro Knauß to branch master.

- Commit Hook


On March 9, 2013, 11:43 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109367/
> -----------------------------------------------------------
> 
> (Updated March 9, 2013, 11:43 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This function should not be used anymore, like the documentation says:
> 
>   /**
>    * The origin and purpose of this function is unknown, the ancient wisdom about it got lost during
>    * the centuries.
>    *
>    * Historicans believe that the intent of the function is to return the raw body of the mail,
>    * i.e. no charset decoding has been done yet. Sometimes CTE decoding has been done, sometimes
>    * not. For encrypted parts, this returns the content of the decrypted part. For a mail with
>    * multiple MIME parts, the results are conecated together. Not all parts are included in this.
>    *
>    * Although conecating multiple undecoded body parts with potentially different CTEs together might
>    * not seem to make any sense in these modern times, it is assumed that initally this function
>    * performed quite well, but the ancient scrolls got damaged with the ravages of time
>    * and were re-written multiple times.
>    *
>    * Do not use. Use plainTextContent() and htmlContent() instead.
>    */
> 
> 
> Diffs
> -----
> 
>   messageviewer/objecttreeparser.h b09ecf19f356be1970815f00add475b369e54d3d 
> 
> Diff: http://git.reviewboard.kde.org/r/109367/diff/
> 
> 
> Testing
> -------
> 
> complies successfully afterwards. Used in five functions in kdepim.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/