[Kde-pim] Review Request 109325: fixing tests in messageviewer

[Andras Mantia]

Laurent Montel wrote:

> For me fix and potential break kmail/messageviewer to fix a unittest is
> not correct. until now nobody reported a bug about it.
> I prefere a unittest broken that a messageviewer/messagecomposer broken.
> until you prouve that it's correct and not break it, I don't want that you
> commit it. Regards.
> 


Well, either we trust a test or remove it. Keeping it failing just because 
nobody understands or wants to find out how the OTP works is not a solution. 
Either we write unit tests that makes sense, or we don't use them and test 
in another way, like you have said: if nobody reported it is broken, it 
means it works.
 I can accept also that, although for the OTP i'd strongly recommend having 
unit tests.

Andras
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/