[Kde-pim] Review Request 109361: Fixing some coding style, spelling issues.

[Kevin Krammer]

> On March 10, 2013, noon, Kevin Krammer wrote:
> > Looks good, testing...

One change doesn't compile:
/dvl/kde/source/kde/kdepim/akregator/plugins/mk4storage/metakit/src/field.cpp:86:44: error: ambiguous overload for 'operator+' in ''[' + c4_Field::DescribeSubFields(bool) const(((int)anonymous_))'

Seems the string type used there doesn't have operators for appending single chars


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109361/#review28872
-----------------------------------------------------------


On March 9, 2013, 4:34 a.m., Jai  Luthra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109361/
> -----------------------------------------------------------
> 
> (Updated March 9, 2013, 4:34 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Fixed some Krazy issues, main focus on proper coding style,  correcting spelling errors, and changing uppercase TRUE/FALSE macros to lowercase.
> 
> 
> Diffs
> -----
> 
>   akregator/plugins/mk4storage/metakit/src/field.cpp 34cc912 
>   akregator/plugins/mk4storage/metakit/src/handler.cpp 571a534 
>   akregator/plugins/mk4storage/metakit/src/mfc.h 6009ee5 
>   akregator/plugins/mk4storage/metakit/src/persist.cpp c57d867 
>   akregator/plugins/mk4storage/metakit/src/store.cpp dad21e4 
>   calendarsupport/CMakeLists.txt 3b40cb3 
>   calendarsupport/calendarutils.cpp 55c003b 
>   calendarsupport/eventarchiver.cpp 7e4322a 
>   calendarsupport/incidenceattachmentmodel.h a14b715 
>   calendarsupport/utils.h 39df587 
>   kleopatra/utils/kdpipeiodevice.cpp f1867d5 
>   messageviewer/invitationsettings.cpp 08fe7b4 
>   messageviewer/mailwebview_webkit.cpp 166c559 
>   messageviewer/objecttreeparser.h b09ecf1 
> 
> Diff: http://git.reviewboard.kde.org/r/109361/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jai  Luthra
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/