[Kde-pim] Review Request 104181: Add new "default" fields to KPIMIdentities::Identity

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104181/
-----------------------------------------------------------

(Updated March 12, 2013, 7:18 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM and KDEPIM-Libraries.


Description
-------

The KABC::StdAddressBook class has been deprecated and KPIMIdentities is the suggested replacement.  Unfortunately, many of the fields that were available in StdAddressBook are missing in the Identity class.  It's possible to use the property() and setProperty() methods to store custom fields, but that means that different apps might use different field names for things like home phone number and locality (city).  

We use this functionality in KOffice to store information about the document author.  Internally, we can just use the property methods, but it would be nice to have interoperability with other applications (such as KAddressBook).  

This patch adds methods for accessing some of the missing fields (the ones we use in KOffice).  Some of the functionality of StdAddressBook is still missing -- instead of a list of phone numbers, I hardwired in a "Home" and "Work" phone number -- but it is a step forward.

This is code I am not that familiar with, but it seems pretty straightforward.  I welcome any comments/constructive criticism.


Diffs
-----

  kalarmcal/CMakeLists.txt 0c0e956 
  kpimidentities/CMakeLists.txt 7b1569d 
  kpimidentities/identity.h b0d0e7c 
  kpimidentities/identity.cpp e1023b3 

Diff: http://git.reviewboard.kde.org/r/104181/diff/


Testing
-------

kdepimlibs compiles and passes the same unit tests it did before the change.  Unfortunately, I just switched my main development computer to Kubuntu from Archlinux (which made testing library changes very easy) and am still trying to figure out the best way to test library changes without clobbering the system packages.  Any suggestions/help would be much appreciated.


Thanks,

Robert Mathias Marmorstein

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/