[Kde-pim] Review Request 109263: Add convenience method Collection::displayName()

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109263/#review28458
-----------------------------------------------------------



akonadi/collection.h
<http://git.reviewboard.kde.org/r/109263/#comment21252>

    I think you can omit Akonadi:: Doxygen should find the class nevertheless since it is in the same namespace 



krss/feedpropertiescollectionattribute.h
<http://git.reviewboard.kde.org/r/109263/#comment21253>

    unwanted whitespace change?


Looks good, minor nitpicking ;)

- Kevin Krammer


On March 3, 2013, 4:37 p.m., Frank Osterfeld wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109263/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 4:37 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Volker Krause.
> 
> 
> Description
> -------
> 
> Add convenience method Collection::displayName()
> 
> The method returns the EntityDisplayAttribute::displayName() if set,
> and name() as fallback. That should help to get more consistent
> collection titles in the UI, where currently sometimes the displayName
> and sometimes name() is used.
> 
> 
> Diffs
> -----
> 
>   akonadi/collection.h 7c8c5bf 
>   akonadi/collection.cpp 7514406 
>   krss/feedpropertiescollectionattribute.h 79a0a3b 
> 
> Diff: http://git.reviewboard.kde.org/r/109263/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frank Osterfeld
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/