[Kde-pim] Review Request 109637: remove the <TAB>s for kdepimlibs/kalarm

[David Jarvie]

> On March 21, 2013, 9:48 a.m., David Jarvie wrote:
> > Could you please replace each tab with 4 spaces instead of 8. That will keep the indentation consistent both within the file and within the library.
> 
> Guy Maurel wrote:
>     Well! The "standard" value for TAB is 8.
>     One the the next step is to correct all the intentations.
>     If it is possible for you "to wait", it will be corrected at that step.
>     Do you?

I don't see why we have to stick to an arbitrary procedure which only allows one rigidly defined step to be done at a time. If you can't replace the tabs by 4 spaces, I'll happily do it instead. The tabs should have been replaced by 4 spaces a long time ago when I reformatted the whole of KAlarm, but somehow they got missed.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109637/#review29616
-----------------------------------------------------------


On March 21, 2013, 8:16 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109637/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 8:16 a.m.)
> 
> 
> Review request for KDEPIM-Libraries, David Jarvie and Kevin Krammer.
> 
> 
> Description
> -------
> 
> According the discussion in Berlin KDEPIM-Meeting and http://techbase.kde.org/Policies/Kdepim_Coding_Style#Migration
> I put the <TAB>s away
> 
> 
> Diffs
> -----
> 
>   kalarmcal/kacalendar.cpp cbe1c5b 
> 
> Diff: http://git.reviewboard.kde.org/r/109637/diff/
> 
> 
> Testing
> -------
> 
> Tested for CMAKE_BUILD_TYPE "release" and"debug" with http://techbase.kde.org/Policies/Kdepim_Coding_Style#Check_the_objects
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/