[Kde-pim] Review Request 109250: Fetch missing body parts in the IMAP resource. Part 3/3

[Andras Mantia]

> On March 3, 2013, 10:05 a.m., Kevin Krammer wrote:
> > resources/imap/retrieveitemstask.cpp, line 46
> > <http://git.reviewboard.kde.org/r/109250/diff/1/?file=116630#file116630line46>
> >
> >     Position of * at variable

I should patch KDevelop. :) Fixed.


> On March 3, 2013, 10:05 a.m., Kevin Krammer wrote:
> > resources/imap/retrieveitemstask.cpp, line 83
> > <http://git.reviewboard.kde.org/r/109250/diff/1/?file=116630#file116630line83>
> >
> >     IMHO it would be preferable to have a longer line than this line break

Tell to the other Kevin (that condition is copy pasted). :)


> On March 3, 2013, 10:05 a.m., Kevin Krammer wrote:
> > resources/imap/retrieveitemstask.cpp, line 104
> > <http://git.reviewboard.kde.org/r/109250/diff/1/?file=116630#file116630line104>
> >
> >     const Akonadi::Item::List?

Fixed


> On March 3, 2013, 10:05 a.m., Kevin Krammer wrote:
> > resources/imap/retrieveitemstask.cpp, line 353
> > <http://git.reviewboard.kde.org/r/109250/diff/1/?file=116630#file116630line353>
> >
> >     is this on the same column as fetch?

No, but fixed now.


> On March 3, 2013, 10:05 a.m., Kevin Krammer wrote:
> > resources/imap/retrieveitemstask.cpp, line 424
> > <http://git.reviewboard.kde.org/r/109250/diff/1/?file=116630#file116630line424>
> >
> >     space before m_fetchedMissingBodies

Fixed


> On March 3, 2013, 10:05 a.m., Kevin Krammer wrote:
> > resources/imap/retrieveitemstask.cpp, line 435
> > <http://git.reviewboard.kde.org/r/109250/diff/1/?file=116630#file116630line435>
> >
> >     no reset in error case?

Right, fixed.


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109250/#review28426
-----------------------------------------------------------


On March 3, 2013, 10:04 a.m., Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109250/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 10:04 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Ottens and Volker Krause.
> 
> 
> Description
> -------
> 
> This part makes sure the IMAP resources caches the full body if it was missing for whatever reason from the cache. This covers the transition from an online IMAP account to a disconnected one, and also fixes the cache if it was corrupted (as it happened in any KDE < master so far on account removal).
> 
> 
> Diffs
> -----
> 
>   resources/imap/imapresource.h 078d202 
>   resources/imap/imapresource.cpp 9471eb3 
>   resources/imap/resourcetask.h 3893a5d 
>   resources/imap/retrieveitemstask.h 672171a 
>   resources/imap/retrieveitemstask.cpp cf96dc8 
> 
> Diff: http://git.reviewboard.kde.org/r/109250/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras Mantia
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/